chore: normalize repository URLs#19
Conversation
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @EffortlessSteven, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a necessary maintenance task by updating all references to the repository's GitHub URL. The change reflects a shift in ownership or organization, ensuring that all documentation, metadata, and internal links correctly point to the Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly updates most repository URLs from cmrigney/shipper to effortlessmetrics/shipper. The changes are a good step towards normalizing the repository path.
However, to fully complete the normalization, I noticed a few Cargo.toml files that still use a different casing (EffortlessMetrics) for the organization name. While GitHub URLs are case-insensitive, using a consistent lowercase effortlessmetrics everywhere would be ideal for normalization.
The files I noticed are:
crates/shipper/Cargo.toml(homepageandrepositoryfields)crates/shipper-cli/Cargo.toml(documentation,homepage, andrepositoryfields)
I recommend updating these files as part of this PR to ensure complete consistency. Since these files are not part of the current changes, I'm mentioning it here in the general feedback. Other than this, the changes look good.
There was a problem hiding this comment.
Pull request overview
Normalizes repository links throughout the workspace by updating documentation and crate metadata references from cmrigney/shipper to effortlessmetrics/shipper, keeping URLs aligned with the project’s current GitHub location.
Changes:
- Updated GitHub links in contributor, roadmap, and security documentation.
- Updated
shipper-retrycrate metadatarepositoryURL. - Updated the library rustdoc changelog link to the new GitHub org.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
CONTRIBUTING.md |
Replaces GitHub discussion/issue URLs to point at the new org. |
ROADMAP.md |
Updates the roadmap’s “suggest a feature” Issues link. |
SECURITY.md |
Updates advisory, releases, issues, and clone URLs to the new org. |
crates/shipper-retry/Cargo.toml |
Updates crate metadata repository URL to the new org. |
crates/shipper/src/lib.rs |
Updates rustdoc changelog link to the new org. |
| rust-version.workspace = true | ||
| description = "Retry strategies and backoff policies for shipper" | ||
| repository = "https://github.com/cmrigney/shipper" | ||
| repository = "https://github.com/effortlessmetrics/shipper" |
There was a problem hiding this comment.
repository URL casing is inconsistent with the rest of the workspace crates (most use https://github.com/EffortlessMetrics/shipper). To avoid introducing another variant while “normalizing” URLs, align this value with the existing Cargo.toml convention (or update all crate metadata consistently in the same PR).
| repository = "https://github.com/effortlessmetrics/shipper" | |
| repository = "https://github.com/EffortlessMetrics/shipper" |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Summary
cmrigney/shippertoeffortlessmetrics/shipperacross docs and crate metadataFiles changed
CONTRIBUTING.mdROADMAP.mdSECURITY.mdcrates/shipper-retry/Cargo.tomlrepositoryfieldcrates/shipper/src/lib.rsTest plan