Skip to content

chore(msrv): probe Rust 1.95 compatibility#170

Merged
EffortlessSteven merged 1 commit into
mainfrom
probe/rust-1.95-compat
May 10, 2026
Merged

chore(msrv): probe Rust 1.95 compatibility#170
EffortlessSteven merged 1 commit into
mainfrom
probe/rust-1.95-compat

Conversation

@EffortlessSteven

@EffortlessSteven EffortlessSteven commented May 10, 2026

Copy link
Copy Markdown
Member

Summary

Probe the workspace under Rust 1.95.0 before raising the declared MSRV. Result: clean — no source changes required.

Audit note: docs/audits/rust-1.95-compatibility.md

Probe Results

Check Result
cargo fmt --all -- --check Clean
cargo check --workspace --all-targets --all-features --locked Clean
cargo clippy -- -D warnings Clean (zero warnings)
cargo doc --workspace --no-deps Clean
git diff --check Clean

New Clippy 1.95 lints (manual_checked_ops, manual_take, manual_pop_if, duration_suboptimal_units, unnecessary_trailing_comma) do not fire on the current codebase.

No Code Changes

This PR adds only docs/audits/rust-1.95-compatibility.md. No Cargo.toml, toolchain, workflow, or source changes.

Test plan

  • cargo fmt --all -- --check — clean
  • cargo check --workspace --all-targets --locked — clean
  • git diff --check — clean
  • No source changes
  • Audit note documents pre-existing cargo test vs cargo nextest distinction

Self-review

  • Scope matches PR title: yes — compat probe audit note only
  • Files touched are expected: yes — docs/audits/rust-1.95-compatibility.md only
  • No unrelated cleanup: yes
  • Policy changes are intentional: n/a
  • No Clippy test carveouts added: n/a
  • No bare #[allow(clippy::...)] added: n/a
  • No-panic baseline handling is scoped: n/a
  • Non-Rust allowlist changes are narrow: n/a
  • Release dogfood proof preserved: yes
  • Trusted Publishing/resume behavior unchanged: yes — no code changes
  • Local validation: all checks clean
  • CI status: pending
  • Bot comments addressed: n/a (new PR)
  • Follow-ups: PR 3 (MSRV/toolchain bump) proceeds from this confirmation

https://claude.ai/code/session_0144KiDnuVJV9ACganxqHK72

Generated by Claude Code

@claude
chore(msrv): probe Rust 1.95 compatibility
86a9daf 
Run the workspace under rustc 1.95.0 before raising the declared MSRV.

Result: clean — no source changes required. fmt, check, clippy (-D
warnings), and doc all pass without modification. The 22 cargo-test
failures in e2e_expanded are pre-existing (identical on stable 1.92)
and caused by insta snapshot tests that require cargo nextest, which CI
uses and which passes.

New Clippy 1.95 lints (manual_checked_ops, manual_take, manual_pop_if,
duration_suboptimal_units, unnecessary_trailing_comma) do not fire on
the current codebase.

Audit note: docs/audits/rust-1.95-compatibility.md

https://claude.ai/code/session_0144KiDnuVJV9ACganxqHK72
@gemini-code-assist

gemini-code-assist Bot commented May 10, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented May 10, 2026 •
edited
Loading

Copy link
Copy Markdown

Warning

Rate limit exceeded

@EffortlessSteven has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 22 minutes and 9 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 73305825-5ce5-47b9-bf42-d7b90ba25538

📥 Commits

Reviewing files that changed from the base of the PR and between 90c4aaa and 86a9daf.

📒 Files selected for processing (1)
  • docs/audits/rust-1.95-compatibility.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch probe/rust-1.95-compat

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@EffortlessSteven EffortlessSteven marked this pull request as ready for review May 10, 2026 22:22
@gemini-code-assist

gemini-code-assist Bot commented May 10, 2026

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented May 10, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@EffortlessSteven EffortlessSteven merged commit 4ce4999 into main May 10, 2026
18 checks passed
@EffortlessSteven EffortlessSteven mentioned this pull request May 10, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@EffortlessSteven @claude