chore: update Effect v4 beta dependencies (#719)

mattiamanzati · web-flow · commit d23980a78550 · 2026-04-07T18:47:18.000+02:00
diff --git a/.changeset/fair-ducks-applaud.md b/.changeset/fair-ducks-applaud.md
@@ -0,0 +1,5 @@
+---
+"@effect/language-service": patch
+---
+
+Update the Effect v4 beta dependencies to `4.0.0-beta.43` for the language service and v4 harness packages.
diff --git a/packages/harness-effect-v4/package.json b/packages/harness-effect-v4/package.json
@@ -6,7 +6,7 @@
   },
   "dependencies": {
     "@standard-schema/spec": "^1.1.0",
-    "effect": "^4.0.0-beta.38"
+    "effect": "^4.0.0-beta.43"
   },
   "devDependencies": {
     "@types/node": "^25.0.6"
diff --git a/packages/language-service/package.json b/packages/language-service/package.json
@@ -43,10 +43,10 @@
     "perf": "tsx test/perf.ts"
   },
   "devDependencies": {
-    "@effect/platform-node": "^4.0.0-beta.38",
+    "@effect/platform-node": "^4.0.0-beta.43",
     "@types/pako": "^2.0.4",
     "@typescript-eslint/project-service": "^8.52.0",
-    "effect": "^4.0.0-beta.38",
+    "effect": "^4.0.0-beta.43",
     "pako": "^2.1.0",
     "ts-patch": "^3.3.0"
   }
diff --git a/packages/language-service/src/cli/overview.ts b/packages/language-service/src/cli/overview.ts
@@ -136,6 +136,7 @@ export function collectExportedItems(
       // Check if it's a Context.Tag (has _Identifier and _Service variance)
       const contextTagResult = yield* pipe(
         typeParser.contextTag(type, declaration),
+        Nano.orElse(() => typeParser.serviceType(type, declaration)),
         Nano.option
       )
       if (Option.isSome(contextTagResult)) {
diff --git a/packages/language-service/src/core/TypeParser.ts b/packages/language-service/src/core/TypeParser.ts
@@ -1628,40 +1628,32 @@ export function make(
       ([Identifier, Service]) => ({ Identifier, Service })
     )
 
-  const serviceVarianceStruct = (
-    type: ts.Type,
-    atLocation: ts.Node
-  ) =>
-    Nano.map(
-      Nano.all(
-        varianceStructInvariantType(type, atLocation, "_Identifier"),
-        varianceStructInvariantType(type, atLocation, "_Service")
-      ),
-      ([Identifier, Service]) => ({ Identifier, Service })
-    )
-
   const serviceType = Nano.cachedBy(
     Nano.fn("TypeParser.serviceType")(function*(
       type: ts.Type,
       atLocation: ts.Node
     ) {
+      // v4 only
+      if (supportedEffect() !== "v4") return yield* typeParserIssue("v4 only")
       // should be pipeable
       yield* pipeableType(type, atLocation)
-      // get the properties to check (exclude non-property and optional properties)
-      const propertiesSymbols = typeChecker.getPropertiesOfType(type).filter((_) =>
-        _.flags & ts.SymbolFlags.Property && !(_.flags & ts.SymbolFlags.Optional) && _.valueDeclaration
-      )
-      // early exit
-      if (propertiesSymbols.length === 0) {
-        return yield* typeParserIssue("Type has no tag variance struct", type, atLocation)
+      // Effect v4 beta.43 switched ServiceMap keys from nested variance markers
+      const typeIdSymbol = typeChecker.getPropertyOfType(type, "~effect/ServiceMap/Service")
+      if (!typeIdSymbol) {
+        return yield* typeParserIssue("Type has no service key type id", type, atLocation)
       }
-      // try to put typeid first (heuristic to optimize hot path)
-      propertiesSymbols.sort((a, b) => ts.symbolName(b).indexOf("TypeId") - ts.symbolName(a).indexOf("TypeId"))
-      // has a property symbol which is a service variance struct
-      return yield* Nano.firstSuccessOf(propertiesSymbols.map((propertySymbol) => {
-        const propertyType = typeChecker.getTypeOfSymbolAtLocation(propertySymbol, atLocation)
-        return serviceVarianceStruct(propertyType, atLocation)
-      }))
+      const identifierSymbol = typeChecker.getPropertyOfType(type, "Identifier")
+      if (!identifierSymbol) {
+        return yield* typeParserIssue("Type has no 'Identifier' property", type, atLocation)
+      }
+      const serviceSymbol = typeChecker.getPropertyOfType(type, "Service")
+      if (!serviceSymbol) {
+        return yield* typeParserIssue("Type has no 'Service' property", type, atLocation)
+      }
+      return ({
+        Identifier: typeChecker.getTypeOfSymbolAtLocation(identifierSymbol, atLocation),
+        Service: typeChecker.getTypeOfSymbolAtLocation(serviceSymbol, atLocation)
+      })
     }),
     "TypeParser.serviceType",
     (type) => type
@@ -1672,6 +1664,8 @@ export function make(
       type: ts.Type,
       atLocation: ts.Node
     ) {
+      // v4 only
+      if (supportedEffect() !== "v3") return yield* typeParserIssue("v3 only")
       // should be pipeable
       yield* pipeableType(type, atLocation)
       // get the properties to check (exclude non-property and optional properties)
diff --git a/packages/language-service/src/diagnostics/genericEffectServices.ts b/packages/language-service/src/diagnostics/genericEffectServices.ts
@@ -45,6 +45,7 @@ export const genericEffectServices = LSP.createDiagnostic({
       for (const [type, reportAt] of typesToCheck) {
         yield* pipe(
           typeParser.contextTag(type, node),
+          Nano.orElse(() => typeParser.serviceType(type, node)),
           Nano.map(() => {
             report({
               location: reportAt,
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +"@effect/language-service": patch
 +---
++
 +Update the Effect v4 beta dependencies to `4.0.0-beta.43` for the language service and v4 harness packages.
Original file line number	Diff line number	Diff line change
`@@ -136,6 +136,7 @@ export function collectExportedItems(`
`136`	`136`	`// Check if it's a Context.Tag (has _Identifier and _Service variance)`
`137`	`137`	`const contextTagResult = yield* pipe(`
`138`	`138`	`typeParser.contextTag(type, declaration),`
	`139`	`+ Nano.orElse(() => typeParser.serviceType(type, declaration)),`
`139`	`140`	`Nano.option`
`140`	`141`	`)`
`141`	`142`	`if (Option.isSome(contextTagResult)) {`