Skip to content

Add Cron.prev reverse iteration support#5786

Merged
fubhy merged 14 commits intonext-minorfrom
cron-prev-polish
Jan 7, 2026
Merged

Add Cron.prev reverse iteration support#5786
fubhy merged 14 commits intonext-minorfrom
cron-prev-polish

Conversation

@kitlangton
Copy link
Contributor

@kitlangton kitlangton commented Nov 21, 2025 •
edited
Loading

Summary

  • add backward cron traversal with shared lookup tables and last-boundary resets
  • align DST handling while walking backward and add reverse sequence iterator
  • expand cron prev/next symmetry tests, DST overlap coverage, step/range backward cases, month/year wrap, and add changeset

Context

Based on @tmcw's fork branch https://github.com/tmcw/effect/tree/cron-prev ; rebased on main and tightened tests/edge cases.
Closes #5666.

Testing

  • pnpm vitest packages/effect/test/Cron.test.ts

@github-project-automation github-project-automation bot moved this to Discussion Ongoing in PR Backlog Nov 21, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 21, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 42e9d0d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 36 packages
Name Type
effect Minor
@effect/cli Major
@effect/cluster Major
@effect/experimental Major
@effect/opentelemetry Major
@effect/platform-browser Major
@effect/platform-bun Major
@effect/platform-node-shared Major
@effect/platform-node Major
@effect/platform Major
@effect/printer-ansi Major
@effect/printer Major
@effect/rpc Major
@effect/sql-clickhouse Major
@effect/sql-d1 Major
@effect/sql-drizzle Major
@effect/sql-kysely Major
@effect/sql-libsql Major
@effect/sql-mssql Major
@effect/sql-mysql2 Major
@effect/sql-pg Major
@effect/sql-sqlite-bun Major
@effect/sql-sqlite-do Major
@effect/sql-sqlite-node Major
@effect/sql-sqlite-react-native Major
@effect/sql-sqlite-wasm Major
@effect/sql Major
@effect/typeclass Major
@effect/vitest Major
@effect/workflow Major
@effect/ai Major
@effect/ai-amazon-bedrock Major
@effect/ai-anthropic Major
@effect/ai-google Major
@effect/ai-openai Major
@effect/ai-openrouter Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@effect-bot effect-bot changed the base branch from main to next-minor November 21, 2025 21:08
@kitlangton kitlangton requested a review from fubhy November 21, 2025 21:31
@kitlangton
Copy link
Contributor Author

kitlangton commented Nov 21, 2025

@copilot tell me I'm beautiful

Copilot AI mentioned this pull request Nov 21, 2025
Closed
Copy link

Copilot AI commented Nov 21, 2025

@kitlangton I've opened a new pull request, #5787, to work on those changes. Once the pull request is ready, I'll request review from you.

@effect-bot effect-bot force-pushed the next-minor branch 10 times, most recently from 6c3c7b6 to a75f668 Compare November 27, 2025 04:41
@effect-bot effect-bot force-pushed the next-minor branch 8 times, most recently from 5540156 to f752fc3 Compare December 13, 2025 05:00
@effect-bot effect-bot force-pushed the next-minor branch 5 times, most recently from 24ae504 to 6bc6da5 Compare December 23, 2025 17:40
@effect-bot effect-bot force-pushed the next-minor branch 6 times, most recently from 3819093 to d0dae5b Compare January 2, 2026 15:30
@tmcw tmcw mentioned this pull request Jan 6, 2026
Closed
5 tasks
@tmcw
Copy link
Contributor

tmcw commented Jan 6, 2026

Any chance this can get merged? Would love to drop another dependency in favor of Effect.

@kitlangton
Copy link
Contributor Author

kitlangton commented Jan 6, 2026

@fubhy YOU HAVE DECEIVED US.

@fubhy
Copy link
Member

fubhy commented Jan 7, 2026

OKOK I AM ON IT!

fubhy
fubhy approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@fubhy fubhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to team Cron

@effect-bot effect-bot mentioned this pull request Jan 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fubhy fubhy fubhy approved these changes

@mikearnaldi mikearnaldi Awaiting requested review from mikearnaldi mikearnaldi is a code owner

Assignees

No one assigned

Labels

next-minor

Projects

PR Backlog
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kitlangton @tmcw @fubhy @effect-bot