Skip to content

Fixed memory leak in tarnish by adding process->deleteLater(); #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Eeems merged 1 commit into from
May 10, 2024
Merged

Fixed memory leak in tarnish by adding process->deleteLater(); #353

Eeems merged 1 commit into from
May 10, 2024

Conversation

@stereo-highway
Copy link
Contributor

@stereo-highway stereo-highway commented May 10, 2024

Fixed memory leak in tarnish by adding process->deleteLater();
We were not removing process handle while probing wifi resulting in memory leak.

Fixes #266

Without the fix, heap Rss increases by 8kB everytime the wifi timer is called.

No significant change observed in heap after change:

Every 1.0s: cat 16542/smaps | grep -A20 heap                                                                                 2024-05-09 19:08:05

01a74000-01c4b000 rw-p 00000000 00:00 0          [heap]
Size:               1884 kB
KernelPageSize:        4 kB
MMUPageSize:           4 kB
Rss:                1680 kB
Pss:                1680 kB
Shared_Clean:          0 kB
Shared_Dirty:          0 kB
Private_Clean:         0 kB
Private_Dirty:      1680 kB
Referenced:         1680 kB
Anonymous:          1680 kB
LazyFree:              0 kB
AnonHugePages:         0 kB
ShmemPmdMapped:        0 kB
FilePmdMapped:        0 kB
Shared_Hugetlb:        0 kB
Private_Hugetlb:       0 kB
Swap:                  0 kB
SwapPss:               0 kB
Locked:                0 kB

@Eeems Eeems merged commit 17fd50d into Eeems-Org:master May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Eeems Eeems Eeems approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Memory leak

2 participants

@stereo-highway @Eeems