Skip to content

Conversation

@Eeems
Copy link
Collaborator

@Eeems Eeems commented Jan 7, 2022

Fix #238
Fix #239
Fix #243
Fix #242
Fix #244
Fix #246
Create a shared library to help reduce code size, and provide another API option for people developing applications.

@Eeems Eeems added the enhancement New feature or request label Jan 7, 2022
@Eeems Eeems self-assigned this Jan 7, 2022
@Eeems
Copy link
Collaborator Author

Eeems commented Jan 7, 2022

Managed to find and resolve #239 by using the crash reporting!
https://sentry.eeems.codes/share/issue/9f61bc693e274deabc2d6b56fb39a774/

@Eeems
Copy link
Collaborator Author

Eeems commented Jan 7, 2022

Building in the toltec toolchain is currently blocked by toltec-dev/toolchain#13
@siraben you might want to check to make sure that the nix build can handle this as well.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 527177 lines exceeds the maximum allowed for the inline comments feature.

@Eeems Eeems added this to the v2.4 milestone Jan 7, 2022
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR diff size of 527375 lines exceeds the maximum allowed for the inline comments feature.

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit f7e80f1 and detected 135 issues on this pull request.

Here's the issue category breakdown:

Category Count
Style 80
Performance 3
Compatibility 3
Bug Risk 49

View more on Code Climate.

@commit-lint
Copy link

commit-lint bot commented Jan 8, 2022

Contributors

Eeems

Commit-Lint commands

You can trigger Commit-Lint actions by commenting on this PR:

  • @Commit-Lint merge patch will merge dependabot PR on "patch" versions (X.X.Y - Y change)
  • @Commit-Lint merge minor will merge dependabot PR on "minor" versions (X.Y.Y - Y change)
  • @Commit-Lint merge major will merge dependabot PR on "major" versions (Y.Y.Y - Y change)
  • @Commit-Lint merge disable will desactivate merge dependabot PR
  • @Commit-Lint review will approve dependabot PR
  • @Commit-Lint stop review will stop approve dependabot PR

@Eeems Eeems force-pushed the feature/sentry branch 7 times, most recently from 318c7ae to 02724ff Compare January 8, 2022 04:12
@Eeems Eeems marked this pull request as ready for review February 27, 2022 03:40
@Eeems
Copy link
Collaborator Author

Eeems commented Feb 27, 2022

@LinusCDE would you be willing to test again? The build is now working, so you should be able to get ipk files to simplify the install process.

@LinusCDE
Copy link
Contributor

Will look to do so in the next few days.

@Eeems
Copy link
Collaborator Author

Eeems commented Feb 28, 2022

Will look to do so in the next few days.

@LinusCDE thanks!

@Eeems
Copy link
Collaborator Author

Eeems commented Mar 5, 2022

@LinusCDE did you get a chance to look at this?

@LinusCDE
Copy link
Contributor

LinusCDE commented Mar 5, 2022

@LinusCDE did you get a chance to look at this?

Not yet. Gotta look into some Linux Container/Namespace books the coming weeks anyway and also wanted to look into some new progression fantasy book to read. Was caught up this week, syncing my new backup yubikey and finally did all the openpgp+ssh madness with it (also on my smartphone) as well as setting up gpg signing all commits by default.

@LinusCDE
Copy link
Contributor

Installed oxide from the lasted built packages here:

Mar 24 13:33:48 reMarkable systemd[1]: Starting oxide system service...
Mar 24 13:33:48 reMarkable tarnish[1413]: RM2 detected...
Mar 24 13:33:48 reMarkable tarnish[1413]: Looking for input devices...
Mar 24 13:33:48 reMarkable tarnish[1413]:   Checking event0...
Mar 24 13:33:48 reMarkable tarnish[1413]:     Buttons input device detected
Mar 24 13:33:48 reMarkable tarnish[1413]:   Checking event1...
Mar 24 13:33:48 reMarkable tarnish[1413]:     Wacom input device detected
Mar 24 13:33:48 reMarkable tarnish[1413]:   Checking event2...
Mar 24 13:33:48 reMarkable tarnish[1413]:     Touch input device detected
Mar 24 13:33:48 reMarkable tarnish[1413]: EPD platform plugin loaded!
Mar 24 13:33:48 reMarkable tarnish[1413]: QStandardPaths: XDG_RUNTIME_DIR not set, defaulting to '/tmp/runtime-root'
Mar 24 13:33:48 reMarkable tarnish[1413]: /opt/bin/tarnish: symbol lookup error: /opt/bin/tarnish: undefined symbol: _ZNK5Oxide14SharedSettings29__META_GROUP_applicationUsageEv
Mar 24 13:33:49 reMarkable systemd[1]: tarnish.service: Main process exited, code=exited, status=127/n/a
Mar 24 13:33:49 reMarkable systemd[1]: tarnish.service: Failed with result 'exit-code'.
Mar 24 13:33:49 reMarkable systemd[1]: Failed to start oxide system service.

Using fw version 2.12.1.527 and had some later packages installed already, so I needed to add --force-downgrade.

@Eeems
Copy link
Collaborator Author

Eeems commented Mar 24, 2022

@LinusCDE that's very odd. I'm also running 2.12.1.527 on my rM1, but I'm not having any issues. This might be an issue with the toltec toolchain? I develop with the reMarkable supplied toolchain. Could you try removing all the packages and installing fresh? Maybe it failed to install liboxide properly?

@matteodelabre any ideas?

@Eeems
Copy link
Collaborator Author

Eeems commented Apr 5, 2022

@matteodelabre poke?

@Eeems
Copy link
Collaborator Author

Eeems commented Apr 12, 2022

@LinusCDE did you get a chance to try removing and reinstalling fresh yet?

@LinusCDE
Copy link
Contributor

Will look to do so tomorrow. I did do a full reinstall of oxide which I thought was enough. But should do a toltec reinstallation anyway.

@LinusCDE
Copy link
Contributor

Did update my firmware and rather then reenable, wiped and reinstalled toltec fresh with the instructions from the website. Afterwards I installed all ipkg files from the newest build here and removed ~/.config/Eeems/ to have it as fresh as possible.

I also set /opt/etc/rm2fb.conf to the newest contents of this file and verified that the framebuffer stuff works.

Apr 14 00:36:17 reMarkable systemd[1]: tarnish.service: Main process exited, code=exited, status=127/n/a
Apr 14 00:36:17 reMarkable systemd[1]: tarnish.service: Failed with result 'exit-code'.
Apr 14 00:36:17 reMarkable systemd[1]: Failed to start oxide system service.
Apr 14 00:36:23 reMarkable systemd[1]: tarnish.service: Scheduled restart job, restart counter is at 1.
Apr 14 00:36:23 reMarkable systemd[1]: Stopped oxide system service.
Apr 14 00:36:23 reMarkable systemd[1]: Starting oxide system service...
Apr 14 00:36:23 reMarkable tarnish[359]: /opt/bin/tarnish: error while loading shared libraries: libliboxide.so.2: cannot open shared object file: No such file or directory
Apr 14 00:36:23 reMarkable systemd[1]: tarnish.service: Main process exited, code=exited, status=127/n/a
Apr 14 00:36:23 reMarkable systemd[1]: tarnish.service: Failed with result 'exit-code'.
Apr 14 00:36:23 reMarkable systemd[1]: Failed to start oxide system service.

Seems the file specified is not packaged yet.

@Eeems
Copy link
Collaborator Author

Eeems commented Apr 19, 2022

@LinusCDE looks like I was missing the liboxide package in the build. This should include it.

@LinusCDE
Copy link
Contributor

grafik

The "liblib" in question is installed, but a symlink to [...].2 is missing.

grafik

Adding the symlink manually fixes it for now.

Started without any config (removed ~/.config/Eeems).

Oxide asks for the kind of telemetry, then it asks whether I want a pin. After I select "no pin" or a pin (and then successfully enter one twice), the app freezes forever. I cant access the task manager (swipe from bottom) and systemctl stop tarnish takes forever and I need to resort to killall -9 tarnish to get it to stop.

@LinusCDE
Copy link
Contributor

After starting tarnish again, the launcher properly boots (the pin decision was saved properly) and everything works again. But initial launch currently doesn't work without ssh access and some medium knowledge.

Here is the log again for the first launch until freeze: https://haste.cosmos-ink.net/silucyheky.log

Notably the freeze doesn't log anything beforehand and the last "No pin" message actually appeared with the pin setup dialog. I selected no pin in this instance the the app froze while clicking that.

@Eeems
Copy link
Collaborator Author

Eeems commented Apr 20, 2022

Interesting, I'll try the entire first setup again and poke at fixing the build to include the links.

@Eeems
Copy link
Collaborator Author

Eeems commented May 8, 2022

@LinusCDE This should fix the missing symlinks. I'm not sure what is causing the freeze for you, as I'm unable to replicate it. Could it be a rM2 only issue?

@Eeems Eeems merged commit 803b190 into master May 15, 2022
@Eeems Eeems deleted the feature/sentry branch May 15, 2022 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

4 participants