Fix auto sleep setting bugs #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 28, 2021 13:23
Clicking the reset button in SettingsPopup calls loadSettings, but loadSettings calls setAutoStartApplication via setProperty, and setAutoStartApplication calls saveSettings. This prevents the sleep settings from resetting properly. I moved the saveSettings call to the QML to fix this.
The value of sleepAfter needs to be updated when auto sleep is enabled, otherwise it will remain zero and the checkbox setting will not be saved.
|
Code Climate has analyzed commit 30255cb and detected 0 issues on this pull request. View more on Code Climate. |
Eeems
reviewed
Sep 28, 2021
Collaborator
|
It looks good, but I wont be able to do a test until later this evening. |
Eeems
approved these changes
Sep 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes two bugs: