Fix/issue 356 handling excel headers#359
Merged
Edwardvaneechoud merged 4 commits intomainfrom Mar 19, 2026
Merged
Conversation
✅ Deploy Preview for flowfile-wasm canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements and fixes to the Excel file reading logic in both the core and worker modules, with a focus on handling headers, row selection, and column naming for various engines. It also adds new and updated tests to ensure correct behavior, especially for edge cases involving header rows and date-typed columns.
Excel reading logic improvements:
has_headeroptions are passed to thepl.read_excelfunction when using thexlsx2csvengine, ensuring thathas_headeris passed directly as a top-level argument rather than withinread_options. This change is applied to bothflowfile_coreandflowfile_workermodules. [1] [2]calamineengine by ensuring columns are uniquely named and, in the core module, by using a custom header row extraction viaraw_data_openpyxl. [1] [2]Testing enhancements:
SUPPORT_FILESpath variable, and standardized string formatting and parameter usage for better readability and maintainability. [1] [2]Dependency management:
xlsx2csvas a new dependency inpyproject.tomlto support the CSV-based Excel reading engine.