Merged
Conversation
✅ Deploy Preview for flowfile-wasm canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving exception handling, code clarity, and logging consistency across several modules. The main changes are the addition of exception chaining for better error traceability, minor code cleanups, and some improvements to logging and code formatting.
Exception Handling Improvements:
from eorfrom None) to allHTTPExceptionand custom exception raises inflowfile_core/flowfile_core/artifacts/routes.py,service.py,auth/jwt.py,auth/secrets.py, and other modules for better error traceability and debugging. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Logging and Code Organization:
flowfile_core/flowfile_core/artifacts/service.pyfor consistency and clarity. [1] [2]__all__toflowfile_core/flowfile_core/configs/node_store/__init__.pyto explicitly declare public API of the module.Code Cleanups and Minor Fixes:
flowfile_core/flowfile_core/configs/flow_logger.pyby removing unnecessary variable assignment inwith open. Also, replaced bareexcept:withexcept Exception:for safer exception handling. [1] [2] [3]uuid) fromflowfile_core/flowfile_core/catalog/service.py.# noqa: F821to suppress linter warning for dynamic mimetype infileExplorer/utils.py.build_backends/main_prd.pyand other files.These changes collectively make the codebase more robust, maintainable, and easier to debug.