Skip to content

fixed all ruff linting issues#347

Merged
Edwardvaneechoud merged 3 commits intomainfrom
feature/cleanup-backend-code
Mar 15, 2026
Merged

fixed all ruff linting issues#347
Edwardvaneechoud merged 3 commits intomainfrom
feature/cleanup-backend-code

Conversation

@Edwardvaneechoud
Copy link
Copy Markdown
Owner

This pull request focuses on improving exception handling, code clarity, and logging consistency across several modules. The main changes are the addition of exception chaining for better error traceability, minor code cleanups, and some improvements to logging and code formatting.

Exception Handling Improvements:

  • Added explicit exception chaining (from e or from None) to all HTTPException and custom exception raises in flowfile_core/flowfile_core/artifacts/routes.py, service.py, auth/jwt.py, auth/secrets.py, and other modules for better error traceability and debugging. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]

Logging and Code Organization:

  • Standardized logger initialization location in flowfile_core/flowfile_core/artifacts/service.py for consistency and clarity. [1] [2]
  • Added __all__ to flowfile_core/flowfile_core/configs/node_store/__init__.py to explicitly declare public API of the module.

Code Cleanups and Minor Fixes:

  • Improved file handling and context management in flowfile_core/flowfile_core/configs/flow_logger.py by removing unnecessary variable assignment in with open. Also, replaced bare except: with except Exception: for safer exception handling. [1] [2] [3]
  • Minor code formatting and variable naming improvements in the code generator and user-defined node registry to enhance readability and maintainability. [1] [2] [3] [4] [5]
  • Removed unused import (uuid) from flowfile_core/flowfile_core/catalog/service.py.
  • Added # noqa: F821 to suppress linter warning for dynamic mimetype in fileExplorer/utils.py.
  • Minor refactoring for clarity in build_backends/main_prd.py and other files.

These changes collectively make the codebase more robust, maintainable, and easier to debug.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 14, 2026

Deploy Preview for flowfile-wasm canceled.

Name Link
🔨 Latest commit e1633d6
🔍 Latest deploy log https://app.netlify.com/projects/flowfile-wasm/deploys/69b67c4c7422440008c566de

@Edwardvaneechoud Edwardvaneechoud merged commit d1af449 into main Mar 15, 2026
29 checks passed
@Edwardvaneechoud Edwardvaneechoud deleted the feature/cleanup-backend-code branch March 15, 2026 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant