Add File Manager for Docker mode file uploads and management#326
Merged
Edwardvaneechoud merged 2 commits intomainfrom Feb 9, 2026
Merged
Add File Manager for Docker mode file uploads and management#326Edwardvaneechoud merged 2 commits intomainfrom
Edwardvaneechoud merged 2 commits intomainfrom
Conversation
Adds a new File Manager view accessible only in Docker mode that allows users to upload, list, and delete data files (CSV, Parquet, Excel, JSON, TXT, TSV) in the shared uploads directory. Includes drag-and-drop upload with progress tracking, file listing with search, and delete confirmation. Backend: new /file_manager router with list/upload/delete endpoints that enforce Docker-mode-only access and use the existing SecureFileExplorer for sandboxed file operations. Frontend: FileManagerView with composable pattern matching existing views, reusing central CSS classes (card, btn, form, empty-state, modal, etc.). Navigation uses a new `dockerOnly` flag to hide the tab in Electron mode. https://claude.ai/code/session_012VGACPjFB3eXRpYeC47nDY
✅ Deploy Preview for flowfile-wasm canceled.
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Comprehensive test suite covering: - Docker-mode gating (403 when not in Docker mode) - File listing (empty dir, uploaded files, extension filtering) - Upload (all 7 allowed types, rejection of disallowed extensions, path traversal sanitization, overwrite behavior, size reporting) - Delete (existing/nonexistent files, path traversal rejection, directory rejection, actual removal verification) - Integration round-trip (upload → list → delete cycle) Uses tmp_path fixture with patched storage.uploads_directory to isolate tests from real user data. The storage singleton caches its directories at import time, so we patch both _check_docker_mode and the uploads_directory property. https://claude.ai/code/session_012VGACPjFB3eXRpYeC47nDY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new File Manager feature that enables users to upload, list, and delete data files in Docker mode. This provides a web-based interface for managing CSV, Parquet, Excel, JSON, and text files in the shared volume, addressing the need for file management in containerized deployments.
Key Changes
Backend
flowfile_core/routes/file_manager.py):GET /file_manager/files- List uploaded files with metadataPOST /file_manager/upload- Upload files with validation (extension whitelist, 500MB size limit)DELETE /file_manager/files/{filename}- Delete files with path traversal protectionFLOWFILE_MODEenvironment variable checkSecureFileExplorerto prevent directory traversal attacksFrontend
New API Client (
fileManager.api.ts):New View (
FileManagerView.vue):Composable (
useFileManager.ts):Navigation:
Implementation Details
FLOWFILE_MODE=dockerenvironment variable and hidden from Electron builds