Skip to content

Conversation

@tamarl08
Copy link
Contributor

No description provided.

@desilinguist
Copy link
Collaborator

desilinguist commented Feb 13, 2024

It'll also be nice to link in the other direction – from where we define wandb_credentials to this new top-level section.

@desilinguist
Copy link
Collaborator

Oh, BTW, the W&B report looks really nice! Thanks for dealing with their interface and docs that you don't like :)

@codecov
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6c0c0d4) 95.44% compared to head (7e2885f) 95.44%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #765   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          30       30           
  Lines        3688     3688           
=======================================
  Hits         3520     3520           
  Misses        168      168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

@tamarl08 tamarl08 merged commit bc55306 into main Feb 14, 2024
@delete-merged-branch delete-merged-branch bot deleted the update_wandb_docs branch February 14, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants