Skip to content

Infrastructure for logging to wandb #758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tamarl08 merged 4 commits into from
Dec 10, 2023
Merged

Infrastructure for logging to wandb #758

tamarl08 merged 4 commits into from
Dec 10, 2023

Conversation

@tamarl08
Copy link
Contributor

@tamarl08 tamarl08 commented Dec 6, 2023 •
edited by desilinguist
Loading

This PR adds initial infrastructure for W&B logging, including a configuration field to enable W&B, a wand interface class, documentation and tests.

@pep8speaks
Copy link

pep8speaks commented Dec 6, 2023 •
edited
Loading

Hello @tamarl08! Thanks for updating this PR.

Line 1852:101: E501 line too long (105 > 100 characters)
Line 1859:101: E501 line too long (104 > 100 characters)

Comment last updated at 2023-12-08 16:02:50 UTC

@codecov
Copy link

codecov bot commented Dec 6, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8ac783c) 95.30% compared to head (78541a1) 95.33%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
+ Coverage   95.30%   95.33%   +0.02%     
==========================================
  Files          29       30       +1     
  Lines        3580     3598      +18     
==========================================
+ Hits         3412     3430      +18     
  Misses        168      168

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

desilinguist
desilinguist requested changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason the coverage checks are not being met?

@tamarl08
Copy link
Contributor Author

tamarl08 commented Dec 8, 2023

Is there a reason the coverage checks are not being met?

I added a test for run_configuration with W&B and now it's covered. I don't know why it did not count as covered before, those lines are tested at test_wandb.py

desilinguist
desilinguist approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for adding the new test!

@tamarl08 tamarl08 merged commit 7c09d07 into main Dec 10, 2023
@delete-merged-branch delete-merged-branch bot deleted the wandb_infra branch December 10, 2023 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desilinguist desilinguist desilinguist approved these changes

@slava92 slava92 Awaiting requested review from slava92

@Frost45 Frost45 Awaiting requested review from Frost45

@damien2012eng damien2012eng Awaiting requested review from damien2012eng

+1 more reviewer

@mulhod mulhod mulhod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tamarl08 @pep8speaks @desilinguist @mulhod