Skip to content

Conversation

@desilinguist
Copy link
Collaborator

  • Add support for HistGradientBoosting learners
    • Add imports.
    • Add default parameter grids.
  • Update documentation:
    • Document default fixed parameters and parameter grids.
    • Add the same for Bagging learner that we forgot to do before.
    • Also add explicit notes to all learners that require dense features.
    • Update ransac regressor note to mention base estimators explicitly.
  • Update regression and classification tests.

Again, best way to to test is to try out the new learners with the California and Iris examples.

This PR closes #489.

- add imports
- add default parameter grids
- Document default fixed parameters and parameter grids.
- Add the same for Bagging learner that we forgot to do before.
- Also add explicit notes to all learners that require dense features.
- Update ransac regressor note to mention base estimators explicitly.
@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (90251a2) 95.19% compared to head (df16263) 95.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #743   +/-   ##
=======================================
  Coverage   95.19%   95.19%           
=======================================
  Files          29       29           
  Lines        3538     3538           
=======================================
  Hits         3368     3368           
  Misses        170      170           
Impacted Files Coverage Δ
skll/learner/__init__.py 97.18% <ø> (ø)
skll/utils/constants.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@mulhod mulhod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything worked perfectly. Ran on M1 FYI.

Ran experiments on California and Iris.

Copy link
Contributor

@Frost45 Frost45 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally! Everything works 🎉

@desilinguist desilinguist merged commit 143ff09 into main Jun 26, 2023
@delete-merged-branch delete-merged-branch bot deleted the 489-add-hist-gradient-boosting-learners branch June 26, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add HistGradientBoostingClassifier and HistGradientBoostingRegressor

5 participants