Skip to content

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Jun 15, 2023

  • Add neg_root_mean_squared_error as an allowed regression metric.
  • Add it to the documentation.
  • Add it to one of the tests to confirm that it works.

To test this, run one of the California example config files with this new metric as either the objective or one of the output metrics.

Closes #555.

- Add it as an allowed regression metric.
- Add it to the documentation.
- Add it to one of the tests to confirm that it works.
@codecov
Copy link

codecov bot commented Jun 15, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.08 🎉

Comparison is base (c0ebc36) 95.10% compared to head (fb1ce25) 95.19%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #741      +/-   ##
==========================================
+ Coverage   95.10%   95.19%   +0.08%     
==========================================
  Files          29       29              
  Lines        3535     3535              
==========================================
+ Hits         3362     3365       +3     
+ Misses        173      170       -3     
Impacted Files Coverage Δ
...utils/commandline/compute_eval_from_predictions.py 97.50% <ø> (ø)
skll/utils/constants.py 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist desilinguist merged commit ce40d5b into main Jun 15, 2023
@delete-merged-branch delete-merged-branch bot deleted the 555-add-rmse branch June 15, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add root_mean_squared_error variant of MSE

4 participants