Add type hints to skll.learner module + other refactoring
#734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add type annotations to avoid circular dependencies.
- Modify `skll.utils.constants` to add type hint. - Refactor some learner code as needed.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #734 +/- ##
==========================================
- Coverage 95.26% 95.20% -0.06%
==========================================
Files 29 29
Lines 3461 3504 +43
==========================================
+ Hits 3297 3336 +39
- Misses 164 168 +4
☔ View full report in Codecov by Sentry. |
dblandan
reviewed
May 30, 2023
dblandan
reviewed
May 30, 2023
dblandan
reviewed
May 30, 2023
dblandan
reviewed
May 30, 2023
dblandan
reviewed
May 30, 2023
dblandan
reviewed
May 30, 2023
dblandan
requested changes
May 30, 2023
dblandan
approved these changes
May 30, 2023
mulhod
suggested changes
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
Co-authored-by: Matt Mulholland <mulhodm@gmail.com>
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
mulhod
approved these changes
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
reviewed
May 31, 2023
tamarl08
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
skll.learnerskll.utils.constantsto add type hint.This PR is part of #561.