Add type hints to skll.config module
#729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Also update docstrings to use proper types. - Clean up code to make it improve type inference.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #729 +/- ##
==========================================
+ Coverage 95.35% 95.37% +0.01%
==========================================
Files 28 29 +1
Lines 3404 3415 +11
==========================================
+ Hits 3246 3257 +11
Misses 158 158
☔ View full report in Codecov by Sentry. |
- Define custom types for readability. - Update `skll.config` module to use these custom types.
tamarl08
reviewed
May 15, 2023
tamarl08
reviewed
May 15, 2023
tamarl08
reviewed
May 15, 2023
tamarl08
approved these changes
May 15, 2023
tazin-afrin
approved these changes
May 15, 2023
damien2012eng
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mypypre-commit check.skll/config/__init.pyandskll/config/utils.py.This is the first PR in support of #561, with many more to come.