Skip to content

Apply code formatting and other minor changes. #724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 2 commits into from
May 2, 2023
Merged

Apply code formatting and other minor changes. #724

desilinguist merged 2 commits into from
May 2, 2023

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented May 2, 2023

  • Update pre-commit checks.
    • Add black.
    • Replace flake8 and isort with ruff.
    • Update flynt and pre-commit versions.
  • Run pre-commit checks
    • Run black on all files.
    • Run ruff on all files. Fix where possible and add "noqa" to others.

This PR closes #639 and closes #723.

@desilinguist
chore: update pre-commit checks
37fe75d 
- Add black.
- Replace flake8 and isort with ruff.
- Update flynt and pre-commit versions.
@desilinguist
chore: apply pre-commit checks
83e6fb6 
- Run black on all files.
- Run `ruff` on all files. Fix where possible and add "noqa" to others.
@desilinguist desilinguist merged commit 1e5d472 into main May 2, 2023
@delete-merged-branch delete-merged-branch bot deleted the 639-black branch May 2, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damien2012eng damien2012eng damien2012eng approved these changes

@tamarl08 tamarl08 tamarl08 approved these changes

@mulhod mulhod Awaiting requested review from mulhod

@slava92 slava92 Awaiting requested review from slava92

@Frost45 Frost45 Awaiting requested review from Frost45

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use ruff to replace flake8 and isort in pre-commit checks Consider using a code formatter

4 participants

@desilinguist @damien2012eng @tamarl08