Update dependencies, consolidate requirements, and tweak coverage #721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frost45
approved these changes
Jan 18, 2023
Codecov ReportBase: 96.91% // Head: 95.36% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #721 +/- ##
==========================================
- Coverage 96.91% 95.36% -1.55%
==========================================
Files 63 28 -35
Lines 9292 3386 -5906
==========================================
- Hits 9005 3229 -5776
+ Misses 287 157 -130 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tamarl08
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
>=1.2.0,<1.3.0since SKLL usually doesn't break for patch updates to scikit-learn.nose-covand modify the CI configuration files to usecoveragedirectly..coveragercfile.pyproject.tomland add.isort.cfgfile since the former interferes with test coverage computation.Larslearner since it's no longer needed with scikit-learn v1.2.0.Note: the coverage number is a little lower because previously we were accidentally including the
examplesandtestsfolders in the coverage results which obviously makes no sense.