Added a utility method to the Learner class returning feature names #715
Conversation
|
hold off on review while I add tests |
Codecov ReportBase: 96.90% // Head: 96.90% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #715 +/- ##
=======================================
Coverage 96.90% 96.90%
=======================================
Files 63 63
Lines 9271 9271
=======================================
Hits 8984 8984
Misses 287 287 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
desilinguist
left a comment
There was a problem hiding this comment.
Looks pretty good but I have some suggestions - some mostly cosmetic but one to actually increase the test coverage check which is failing right now.
remo-help
left a comment
There was a problem hiding this comment.
addressed PR comments
Added a utility method to the Learner class, allowing it to return an array of feature names after the selector step.
c35ce14 to
f3d5658
Compare
This PR adds a simple utility method to the Learner class, allowing it to return the feature names used at the estimator step as a 1-D array.
Learners with a selector potentially have a smaller feature name list than is stored in the feature_vectorizer. This method allows for easy access of the actual feature names of features used, even if the selector has removed specific features.