Skip to content

Conversation

@desilinguist
Copy link
Collaborator

This PR closes #701 and closes #710.

  • Update version number.
  • Update conda recipe. Make it a noarch recipe again based on the conda-forge recipe. Remove conda_build_config.yaml since we don’t need it anymore. Also update the conda-recipe README.
  • Drop Python 3.7 from the README and from setup.py.
  • Use Python 3.8 for ReadTheDocs builds as well.

The conda package has been uploaded to the ets channel. The source tarball has also been uploaded to the test.pypi.org. See passing builds on Linux and Windows for both packages below.

Please test both the packages on macOS and look at the drafted release notes as part of reviewing this PR.

- Make it a noarch Python recipe again.
- Remove unnecessary build requirements.
- Remove `conda_build_config.yaml` file since we are doing a noarch recipe now.
@desilinguist desilinguist requested review from a user, Frost45, damien2012eng and mulhod December 21, 2021 02:20
@codecov
Copy link

codecov bot commented Dec 21, 2021

Codecov Report

Merging #711 (c02377b) into main (61bef9c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   96.90%   96.90%           
=======================================
  Files          63       63           
  Lines        9263     9263           
=======================================
  Hits         8976     8976           
  Misses        287      287           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
skll/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bef9c...c02377b. Read the comment docs.

Co-authored-by: Binod Gyawali <bgyawali@ets.org>
@desilinguist desilinguist merged commit 1502fe8 into main Dec 21, 2021
@delete-merged-branch delete-merged-branch bot deleted the release/3.0.0 branch December 21, 2021 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch back to a genric conda recipe Drop support for Python 3.7 and add Python 3.10 instead

4 participants