Skip to content

Add local=True to all run_configuration() calls in tests. #708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 1 commit into from
Dec 20, 2021
Merged

Add local=True to all run_configuration() calls in tests. #708

desilinguist merged 1 commit into from
Dec 20, 2021

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Dec 20, 2021

This PR closes #616.

@desilinguist desilinguist requested review from a user, Frost45, damien2012eng and mulhod December 20, 2021 18:22
@desilinguist desilinguist linked an issue Dec 20, 2021 that may be closed by this pull request
Use local=True in run_configuration calls in unit tests #616
Closed
@codecov
Copy link

codecov bot commented Dec 20, 2021 •
edited
Loading

Codecov Report

Merging #708 (8fa8915) into main (caa9b56) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #708      +/-   ##
==========================================
- Coverage   96.92%   96.90%   -0.03%     
==========================================
  Files          63       63              
  Lines        9263     9263              
==========================================
- Hits         8978     8976       -2     
- Misses        285      287       +2
Impacted Files Coverage Δ
tests/test_voting_learners_expts_2.py 98.82% <ø> (ø)
tests/test_voting_learners_expts_3.py 98.82% <ø> (ø)
tests/test_ablation.py 100.00% <100.00%> (ø)
tests/test_classification.py 100.00% <100.00%> (ø)
tests/test_custom_learner.py 100.00% <100.00%> (ø)
tests/test_cv.py 100.00% <100.00%> (ø)
tests/test_output.py 100.00% <100.00%> (ø)
tests/test_preprocessing.py 100.00% <100.00%> (ø)
tests/test_regression.py 99.64% <100.00%> (ø)
tests/test_voting_learners_expts_1.py 98.38% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update caa9b56...8fa8915. Read the comment docs.

@desilinguist desilinguist merged commit 4c598b7 into main Dec 20, 2021
@delete-merged-branch delete-merged-branch bot deleted the 616-local-true-in-tests-run-configuration branch December 20, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frost45 Frost45 Awaiting requested review from Frost45

@damien2012eng damien2012eng Awaiting requested review from damien2012eng

2 more reviewers

@mulhod mulhod mulhod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use local=True in run_configuration calls in unit tests

3 participants

@desilinguist @mulhod