Fix —drop_blanks for filter_features command line script
#703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes sense to raise an exception as soon as we detect this since futher processing with an empty features array will run into additional issues.
Make it clear that `--drop_blanks` and `--replace_blanks_with` only apply to CSV/TSV files.
This test checks that an exception is correctly raised if `--drop_blanks` removes all rows in the input file.
Codecov Report
@@ Coverage Diff @@
## main #703 +/- ##
=======================================
Coverage 96.89% 96.89%
=======================================
Files 63 63
Lines 9197 9213 +16
=======================================
+ Hits 8911 8927 +16
Misses 286 286
Continue to review full report at Codecov.
|
Collaborator
Author
|
The code coverage issue can be ignored. |
ghost
reviewed
Dec 7, 2021
mulhod
approved these changes
Dec 7, 2021
ghost
approved these changes
Dec 7, 2021
damien2012eng
approved these changes
Dec 7, 2021
Frost45
approved these changes
Dec 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #693.
—drop_blanksremoves all rows in the input file if each of them contains a blank value.—helpoutput forfilter_featuresto make it clear that—drop_blanksand—replace_blanks_withonly apply to CSV/TSV files.