Remove top-level imports #662
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #662 +/- ##
==========================================
- Coverage 95.10% 95.09% -0.01%
==========================================
Files 27 27
Lines 3104 3100 -4
==========================================
- Hits 2952 2948 -4
Misses 152 152
Continue to review full report at Codecov.
|
Collaborator
Author
|
The codecov change is expected since we are removing import lines. |
aoifecahill
approved these changes
Feb 5, 2021
mulhod
approved these changes
Feb 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #661.
In addition, it makes another minor change of passing in the
betaargument as a keyword argument since scikit-learn raises a warning otherwise.