Skip to content

Conversation

@mulhod
Copy link
Contributor

@mulhod mulhod commented Nov 18, 2020

Closes #636

Mainly, this PR has to do with cleaning up some multi-line string concatenations (or removing them altogether when possible). There are a couple other randomish improvements I made as well (like reducing the length of some very long lines or lines where it was easy to do, removing unused parameters from a function used by a test, etc.).

@pep8speaks
Copy link

pep8speaks commented Nov 18, 2020

Hello @mulhod! Thanks for updating this PR.

Line 398:47: E741 ambiguous variable name 'l'

Comment last updated at 2020-11-18 15:53:42 UTC

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #645 (45d13af) into main (48dc473) will not change coverage.
The diff coverage is 90.38%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #645   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          27       27           
  Lines        3093     3093           
=======================================
  Hits         2942     2942           
  Misses        151      151           
Impacted Files Coverage Δ
skll/learner/utils.py 94.94% <57.14%> (ø)
skll/experiments/__init__.py 95.19% <80.00%> (ø)
skll/learner/__init__.py 96.26% <93.33%> (ø)
skll/config/__init__.py 95.09% <100.00%> (ø)
skll/config/utils.py 95.65% <100.00%> (ø)
skll/data/writers.py 94.11% <100.00%> (ø)
skll/experiments/output.py 97.36% <100.00%> (ø)
skll/metrics.py 97.87% <100.00%> (ø)
...utils/commandline/compute_eval_from_predictions.py 97.18% <100.00%> (ø)
skll/utils/commandline/filter_features.py 98.41% <100.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48dc473...45d13af. Read the comment docs.

@mulhod mulhod force-pushed the string_concatenation_etc branch from b14a548 to 45d13af Compare November 18, 2020 15:53
@mulhod
Copy link
Contributor Author

mulhod commented Nov 18, 2020

Why the coverage check is failing I have no idea. When I click on the "Details" link, I don't see any change in coverage... Perhaps I'm not reading it correctly?

Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for taking this on @mulhod!

@mulhod
Copy link
Contributor Author

mulhod commented Nov 23, 2020

@bndgyawali If you get a chance, could you take a look at this? There are quite a few changes, but they are all cosmetic.

@desilinguist desilinguist merged commit 26b96c2 into main Nov 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the string_concatenation_etc branch November 24, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize string concatenation

4 participants