Skip to content

Fix up some cases where open was not done with a context manager, etc. #644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mulhod merged 1 commit into from
Nov 16, 2020
Merged

Fix up some cases where open was not done with a context manager, etc. #644

mulhod merged 1 commit into from
Nov 16, 2020

Conversation

@mulhod
Copy link
Contributor

@mulhod mulhod commented Nov 16, 2020

Closes #641.

@mulhod mulhod force-pushed the open_context_managers branch from 06c4f55 to 0cc101c Compare November 16, 2020 18:15
@codecov
Copy link

codecov bot commented Nov 16, 2020 •
edited
Loading

Codecov Report

Merging #644 (0cc101c) into main (d4811c1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files          27       27           
  Lines        3089     3093    +4     
=======================================
+ Hits         2938     2942    +4     
  Misses        151      151
Impacted Files Coverage Δ
skll/config/utils.py 95.65% <100.00%> (ø)
skll/data/readers.py 90.13% <100.00%> (ø)
skll/experiments/output.py 97.36% <100.00%> (ø)
skll/utils/commandline/generate_predictions.py 98.66% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4811c1...0cc101c. Read the comment docs.

desilinguist
desilinguist approved these changes Nov 16, 2020
View reviewed changes
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍!

ghost
ghost approved these changes Nov 16, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mulhod mulhod merged commit 48dc473 into main Nov 16, 2020
@delete-merged-branch delete-merged-branch bot deleted the open_context_managers branch November 16, 2020 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desilinguist desilinguist desilinguist approved these changes

@aoifecahill aoifecahill Awaiting requested review from aoifecahill

@hlepp hlepp Awaiting requested review from hlepp

@jimmybru jimmybru Awaiting requested review from jimmybru

@rutujaubale rutujaubale Awaiting requested review from rutujaubale

+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use with context manager when opening files

3 participants

@mulhod @desilinguist