Hello @mulhod! Thanks for updating this PR.

• In the file tests/test_featureset.py:

Line 70:101: E501 line too long (134 > 100 characters)

Comment last updated at 2020-11-09 21:27:43 UTC

Codecov Report

Merging #634 (d5d16f6) into main (7a7794f) will increase coverage by 0.00%.
The diff coverage is 78.20%.

@@           Coverage Diff           @@
##             main     #634   +/-   ##
=======================================
  Coverage   95.10%   95.11%           
=======================================
  Files          27       27           
  Lines        3087     3089    +2     
=======================================
+ Hits         2936     2938    +2     
  Misses        151      151           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a7794f...d5d16f6. Read the comment docs.

According to the codecov diff, coverage increases very slightly by 0.01%. So, why the codecov check itself is not passing I'm not really sure.

@mulhod can you push another commit?

Hmm, codecov check still failed.

Or perhaps I'm just reading it wrong? The codecov/patch check failed. But not codecov/project.

Anyway something failed.

Yeah, that's the patch diff that failed – which checks whether any new lines you added are also covered by tests. I am guessing these are because you broke some long strings into smaller ones?

I did break some lines up, but it appears the total didn't change by much. Maybe 2 lines more?

Anyway, it's a little unclear to me how this can be addressed or if it should.

I don't think we need to worry about it.