Skip to content

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented May 6, 2020

This PR closes #486.

  • Add the new metrics to the SCORERS dictionary in skll/__init__.py.
  • Tweak an existing test to also test f05.
  • Add explicit test to test all metric values.
  • Add the new metrics to the documentation.
  • Remove some stray references to megam.
  • Update .gitignore file.

Note: Python doesn't allow periods in variable names so I named the metrics f05, f05_score_micro etc. since it was the fastest to type and remember. Other suggestions welcome!

- Also include them in the set of classification only metrics.
- One in `test_classification.py`.
- Another in `test_metrics.py`
@desilinguist desilinguist requested review from a user, aoifecahill, chaomenghsuan and mulhod May 6, 2020 20:23
@codecov
Copy link

codecov bot commented May 6, 2020

Codecov Report

Merging #607 into master will increase coverage by 1.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #607      +/-   ##
==========================================
+ Coverage   93.75%   95.16%   +1.41%     
==========================================
  Files          26       26              
  Lines        2977     2977              
==========================================
+ Hits         2791     2833      +42     
+ Misses        186      144      -42     
Impacted Files Coverage Δ
skll/utils/constants.py 100.00% <ø> (ø)
skll/config/__init__.py 95.07% <0.00%> (+0.37%) ⬆️
skll/learner/utils.py 96.31% <0.00%> (+0.61%) ⬆️
skll/data/featureset.py 91.13% <0.00%> (+0.63%) ⬆️
skll/experiments/output.py 97.36% <0.00%> (+1.57%) ⬆️
skll/experiments/__init__.py 95.16% <0.00%> (+2.58%) ⬆️
skll/learner/__init__.py 96.28% <0.00%> (+4.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9599ea...d1685c4. Read the comment docs.

Copy link
Collaborator

@aoifecahill aoifecahill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@desilinguist desilinguist merged commit 7b70f31 into master May 9, 2020
@delete-merged-branch delete-merged-branch bot deleted the 486-add-fbeta-0-point-5-metric branch May 9, 2020 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support fbeta score with beta=0.5 as a built-in metric

3 participants