Remove create_label_dict keyword argument from Learner.train()
#605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Modify the `Learner._create_label_dict()` argument so that it internally keeps track of whether `label_dict` has already been set.
Codecov Report
@@ Coverage Diff @@
## master #605 +/- ##
==========================================
- Coverage 95.16% 95.16% -0.01%
==========================================
Files 26 26
Lines 2978 2977 -1
==========================================
- Hits 2834 2833 -1
Misses 144 144
Continue to review full report at Codecov.
|
Collaborator
|
Looks good to me. What about the drop in code coverage (1 line?). Is that just noise? |
Collaborator
Author
Yup, we can ignore that. |
aoifecahill
approved these changes
May 6, 2020
mulhod
approved these changes
May 7, 2020
Contributor
mulhod
left a comment
There was a problem hiding this comment.
Nitpicky typo suggestion. Looks good to me, though!
Co-authored-by: Matt Mulholland <mulhodm@gmail.com>
ghost
approved these changes
May 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #565.
Learner._create_label_dict()argument so that it internally keeps track of whetherlabel_dicthas already been set.cross_validate()/learning_curve()methods and once again when the underlying models are trained.