Skip to content

Conversation

@desilinguist
Copy link
Collaborator

This PR closes #572.

  • Learner.save() now uses the current working directory if only a filename is specified.
  • Added a test.

@desilinguist desilinguist requested review from a user, AVajpayeeJr, Lguyogiro and aoifecahill May 4, 2020 13:29
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #604 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #604   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files          26       26           
  Lines        2976     2978    +2     
=======================================
+ Hits         2832     2834    +2     
  Misses        144      144           
Impacted Files Coverage Δ
skll/learner/__init__.py 96.29% <100.00%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb03537...59cc7af. Read the comment docs.

@desilinguist desilinguist merged commit 547fdd5 into master May 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the 572-save-models-in-current-dir branch May 4, 2020 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Saving models in current directory requires ./

3 participants