Fix Windows log/warnings issue #586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to_log and no longer search for UndefinedMetricWarning (see #585); also temporarily set grid_search_jobs to 1 in this test (will resolve parallelism issue in separate issue)
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 95.02% 95.05% +0.03%
==========================================
Files 20 20
Lines 2974 2974
==========================================
+ Hits 2826 2827 +1
+ Misses 148 147 -1
Continue to review full report at Codecov.
|
Contributor
Author
|
One more review, please? @bndgyawali @jbiggsets @aoifecahill @ananyaganesh @chaomenghsuan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #579.
Because of an issue with the way we were computing correlation, the log/warnings behavior was reacting differently on Windows vs *nix. So, this PR just makes the test use a different objective that wouldn't issue the same warning. Also, an issue will be made to deal with log/warnings behavior when
grid_search_jobsis greater than 1 in unit tests (see #587).