Skip to content

removing megam reader and writer #557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 8 commits into from
May 4, 2020
Merged

removing megam reader and writer #557

desilinguist merged 8 commits into from
May 4, 2020

Conversation

@ghost
Copy link

@ghost ghost commented Oct 15, 2019 •
edited by desilinguist
Loading

This PR closes #532.

Removing megam reader and writer.
Updating comments, and documents mentioning megam
Updating test cases that are using megam file types.

@codecov
Copy link

codecov bot commented Oct 16, 2019 •
edited
Loading

Codecov Report

Merging #557 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
- Coverage   95.16%   95.16%   -0.01%     
==========================================
  Files          26       26              
  Lines        3021     2976      -45     
==========================================
- Hits         2875     2832      -43     
+ Misses        146      144       -2
Impacted Files Coverage Δ
skll/data/readers.py 90.13% <ø> (-0.39%) ⬇️
skll/data/writers.py 94.02% <ø> (-0.37%) ⬇️
skll/utils/commandline/filter_features.py 98.41% <ø> (ø)
skll/utils/commandline/generate_predictions.py 98.59% <ø> (ø)
skll/utils/commandline/join_features.py 98.14% <ø> (ø)
skll/utils/commandline/skll_convert.py 93.05% <ø> (ø)
skll/data/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee5b4a1...a7e068b. Read the comment docs.

@ghost
Copy link
Author

ghost commented Oct 16, 2019

pep8speaks not working?

@ghost ghost requested review from aoifecahill, desilinguist, jbiggsets and mulhod October 16, 2019 02:31
@ghost
Copy link
Author

ghost commented Oct 16, 2019

I do not know what the codecov is doing here. When I ran tests locally, this is what i see

$MPLBACKEND=Agg nosetests -v --with-coverage --cover-package skll -c=.coveragerc tests/test_*py

Name                                              Stmts   Miss  Cover
---------------------------------------------------------------------
skll/__init__.py                                     10      0   100%
skll/config.py                                      313     15    95%
skll/data/__init__.py                                 7      0   100%
skll/data/dict_vectorizer.py                          4      0   100%
skll/data/featureset.py                             158     14    91%
skll/data/readers.py                                294     29    90%
skll/data/writers.py                                184     11    94%
skll/experiments.py                                 603     27    96%
skll/learner.py                                     794     32    96%
skll/logutils.py                                     30      0   100%
skll/metrics.py                                      70      2    97%
skll/utilities/__init__.py                            0      0   100%
skll/utilities/compute_eval_from_predictions.py      71      2    97%
skll/utilities/filter_features.py                    63      1    98%
skll/utilities/generate_predictions.py               93      2    98%
skll/utilities/join_features.py                      54      1    98%
skll/utilities/plot_learning_curves.py               26      2    92%
skll/utilities/print_model_weights.py                59      3    95%
skll/utilities/run_experiment.py                     31      1    97%
skll/utilities/skll_convert.py                       72      5    93%
skll/utilities/summarize_results.py                  18      1    94%
skll/version.py                                       3      0   100%
---------------------------------------------------------------------
TOTAL                                              2957    148    95%
----------------------------------------------------------------------
Ran 4505 tests in 1100.602s

OK

mulhod
mulhod approved these changes Oct 21, 2019
View reviewed changes
doc/utilities.rst Outdated
.. option:: input_file(s)

One or more csv file(s), jsonlines file(s), or megam file(s) (with or without the
One or more csv file(s), or jsonlines file(s) (with or without the
Copy link
Contributor

@mulhod mulhod Oct 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick/question: Get rid of the comma if there are only two things. But, also, why are there only two things? That is, shouldn't we mention all the file types supported here (or link to a section that enumerates them)? It seems strange to focus on CSV and jsonlines exclusively here. Also, I suggest changing "csv" and "jsonlines" to "``.csv``" and "``.jsonlines``" as they are used elsewhere (same applies to additional files added).

@ghost
Copy link
Author

ghost commented Oct 21, 2019

Looks it is ready for review, (or merging). Will address any comments further.

@desilinguist
Copy link
Collaborator

desilinguist commented Apr 11, 2020

@bndgyawali looks like there are some conflicts that need to be resolved based on changes we made for v2.1? Can you please update. Thanks!

@desilinguist
Merge branch 'master' into 532-remove-megam-reader-writer-classes
a204a90 
# Conflicts:
#	doc/run_experiment.rst
#	doc/tutorial.rst
@desilinguist desilinguist requested review from aoifecahill and mulhod May 1, 2020 19:34
desilinguist
desilinguist requested changes May 1, 2020
View reviewed changes
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A suggestion and a question. Very minor stuff.

skll/utils/commandline/generate_predictions.py Outdated
Comment on lines 45 to 46
help='A space-separated list of csv file, or json file, '
'(with or without the label '
Copy link
Collaborator

@desilinguist desilinguist May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we changing this?

Copy link
Author

@ghost ghost May 1, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how it got changed. i will revert it back.

@ghost
Copy link
Author

ghost commented May 1, 2020

A suggestion and a question. Very minor stuff.

I addressed them.

@desilinguist desilinguist merged commit bb03537 into master May 4, 2020
@delete-merged-branch delete-merged-branch bot deleted the 532-remove-megam-reader-writer-classes branch May 4, 2020 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbiggsets jbiggsets Awaiting requested review from jbiggsets

@aoifecahill aoifecahill Awaiting requested review from aoifecahill

@mulhod mulhod Awaiting requested review from mulhod

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove MegaM Reader and Writer classes?

3 participants

@desilinguist @aoifecahill @mulhod