Skip to content

Add Type Hints (Part 4) #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 8 commits into from
Feb 9, 2024
Merged

Add Type Hints (Part 4) #682

desilinguist merged 8 commits into from
Feb 9, 2024

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Feb 7, 2024

Changes

  • Add type hints to reporter.py
  • Fix some typos in docstrings
  • Add type hints to test_utils.py
  • Add type hints to transformer.py
  • Add type hints to writer.py.
  • Fix incorrect number of transformer arguments.
  • Remove unneeded argument from rsmeval tests.

How to review

  • Please check that I have not left any parameters/arguments/return values without type hints.
  • Here's the RTD build for this branch. Check the "API Documentation" section (for the files affected by this MR) to confirm that all types are linked to relevant pages from external documentations (e.g., Python, Numpy, SKLL, stats models etc.) and there are no typos etc.
  • Check for typos and/or weird issues in docstrings.

@desilinguist desilinguist changed the title Add Type Hints (Final Part 4) Add Type Hints (Part 4) Feb 7, 2024
@codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (82a1f66) 96.09% compared to head (38dc5f0) 96.10%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #682      +/-   ##
==========================================
+ Coverage   96.09%   96.10%   +0.01%     
==========================================
  Files          32       32              
  Lines        4505     4517      +12     
==========================================
+ Hits         4329     4341      +12     
  Misses        176      176

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

tamarl08
tamarl08 reviewed Feb 8, 2024
View reviewed changes
tamarl08
tamarl08 reviewed Feb 8, 2024
View reviewed changes
mulhod
mulhod reviewed Feb 8, 2024
View reviewed changes
tamarl08
tamarl08 reviewed Feb 8, 2024
View reviewed changes
tamarl08
tamarl08 reviewed Feb 8, 2024
View reviewed changes
tamarl08
tamarl08 reviewed Feb 9, 2024
View reviewed changes
@desilinguist desilinguist merged commit 32b91b7 into main Feb 9, 2024
@delete-merged-branch delete-merged-branch bot deleted the 326-type-hints-4 branch February 9, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tamarl08 tamarl08 tamarl08 approved these changes

@Frost45 Frost45 Awaiting requested review from Frost45

@damien2012eng damien2012eng Awaiting requested review from damien2012eng

+1 more reviewer

@mulhod mulhod mulhod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desilinguist @mulhod @tamarl08