Remove rsmextra and special sections #676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated steps and `rsmextra` mentions. - Add updated steps based on what we actually do.
- Prevent the `master_section_dict` entry from being directly mutated in `get_ordered_notebook_files()`. - Simplify error message generation in `check_section_order()`.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #676 +/- ##
==========================================
+ Coverage 95.63% 96.11% +0.47%
==========================================
Files 32 32
Lines 4515 4455 -60
==========================================
- Hits 4318 4282 -36
+ Misses 197 173 -24 ☔ View full report in Codecov by Sentry. |
The behavior of `read_json()` has changed in the latest version of `pandas` which is only available for python 3.11. One of the tests in `test_reader` was relying on the old behavior. I simplified the test and the reader function.
Collaborator
Author
|
@tamarl08 @damien2012eng @Frost45 @mulhod this MR is ready for review. Ignore the patch coverage failure – it's expected. |
tamarl08
approved these changes
Jan 26, 2024
damien2012eng
approved these changes
Jan 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rsmextrareferences from code, notebooks, and documentation.reporter.pydue to removal of special sections andrsmextra.Closes #675.