-
Notifications
You must be signed in to change notification settings - Fork 19
Add sections to W&B logging #659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified lines are covered by tests ✅
📢 Thoughts on this report? Let us know!. |
|
I'd like to try these changes in a real scenario. Perhaps we can work together to do that, but it will take some work to do before this is a package that can be installed. |
Co-authored-by: Matt Mulholland <mmulholland@ets.org>
desilinguist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, now that I think about it, we should mention the section stuff in documentation somewhere right?
desilinguist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Metrics are logged to different sections according to the context (rsmtool, rsmeval etc.). That way they appear separately on the W&B run and do not overwrite when more than one module log the same metrics.
All reports are logged to a
reportssection.This PR also updates the RTD configuration to meet the new format of the
buildsection.