-
Notifications
You must be signed in to change notification settings - Fork 19
Enhance wandb logging of evaluation metrics #651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
ffaa0b5 to
d0e14f1
Compare
Contributor
|
LGTM! |
desilinguist
requested changes
Sep 7, 2023
mulhod
approved these changes
Sep 7, 2023
desilinguist
approved these changes
Sep 7, 2023
Collaborator
desilinguist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log all the values of the following tables as run metrics:
consistency,eval_short,true_score_eval. This allows easy comparison between runs in the runs viewlog confusion matrices as custom charts, this also allows comparing between runs - see in the workspace view
@desilinguist @mulhod The changes make the tutorial run quite slow for me. Please test and let me know what you think.
to test add the following to
rsmtool/rsmevaltutorial config (change project name accordingly), and run it in this branch: