Skip to content

Feature/conf matrix double scored data #649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 6 commits into from
Aug 25, 2023
Merged

Feature/conf matrix double scored data #649

desilinguist merged 6 commits into from
Aug 25, 2023

Conversation

@mulhod
Copy link
Contributor

@mulhod mulhod commented Aug 24, 2023 •
edited
Loading

Add in h1/h2 confusion matrix in reports.

Still a draft for the moment.

You can try it out on the rsmtool examples.

@mulhod mulhod self-assigned this Aug 24, 2023
@mulhod mulhod changed the title Feature/conf matrix double scored data Draft: Feature/conf matrix double scored data Aug 24, 2023
@mulhod mulhod marked this pull request as draft August 24, 2023 20:15
@codecov
Copy link

codecov bot commented Aug 24, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (49ebb6d) 95.81% compared to head (40dc6ce) 95.82%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #649   +/-   ##
=======================================
  Coverage   95.81%   95.82%           
=======================================
  Files          32       32           
  Lines        4444     4453    +9     
=======================================
+ Hits         4258     4267    +9     
  Misses        186      186
Files Changed Coverage Δ
rsmtool/analyzer.py 99.16% <100.00%> (+0.01%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

desilinguist
desilinguist reviewed Aug 24, 2023
View reviewed changes
desilinguist
desilinguist reviewed Aug 24, 2023
View reviewed changes
desilinguist
desilinguist requested changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a couple of minor suggestions ...

@desilinguist
Copy link
Collaborator

desilinguist commented Aug 24, 2023 •
edited
Loading

@mulhod you will also need to:

  • update the documentation to include the new output file in the intermediate outputs.
  • update the intermediate files notebook to link to the new file.

@mulhod
Copy link
Contributor Author

mulhod commented Aug 25, 2023 •
edited
Loading

@mulhod you will also need to:

  • update the documentation to include the new output file in the intermediate outputs.
  • update the intermediate files notebook to link to the new file.

I have addressed point 1. Point 2 is already addressed, I think (I didn't have to do anything special for this, I believe):
Screenshot 2023-08-24 at 11 36 38 PM

@mulhod mulhod changed the title Draft: Feature/conf matrix double scored data Feature/conf matrix double scored data Aug 25, 2023
@mulhod mulhod marked this pull request as ready for review August 25, 2023 03:42
@mulhod mulhod requested a review from desilinguist August 25, 2023 03:44
desilinguist
desilinguist approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@desilinguist
Copy link
Collaborator

desilinguist commented Aug 25, 2023

@tamarl08 do you mind taking a look as well?

tazin-afrin
tazin-afrin approved these changes Aug 25, 2023
View reviewed changes
Copy link

@tazin-afrin tazin-afrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too!

@tamarl08
Copy link
Contributor

tamarl08 commented Aug 25, 2023

@mulhod looks good! just one weird issue: in my report the degradation part appears twice, see screenshot:
Screenshot 2023-08-25 at 10 00 57 AM

@desilinguist
Copy link
Collaborator

desilinguist commented Aug 25, 2023 •
edited
Loading

Yes, I missed that! I see it twice too. @mulhod can you double check please?

@mulhod
Copy link
Contributor Author

mulhod commented Aug 25, 2023

@tamarl08 Good catch! I see what's happening. Minor issue.

@desilinguist desilinguist merged commit a05138b into main Aug 25, 2023
@delete-merged-branch delete-merged-branch bot deleted the feature/conf_matrix_double_scored_data branch August 25, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@desilinguist desilinguist desilinguist approved these changes

@tazin-afrin tazin-afrin tazin-afrin approved these changes

@tamarl08 tamarl08 tamarl08 approved these changes

@dblandan dblandan Awaiting requested review from dblandan

@armoredcats armoredcats Awaiting requested review from armoredcats

@Frost45 Frost45 Awaiting requested review from Frost45

@blongwill blongwill Awaiting requested review from blongwill

@damien2012eng damien2012eng Awaiting requested review from damien2012eng

Assignees

@mulhod mulhod

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mulhod @desilinguist @tamarl08 @tazin-afrin