Update pre-commit checks #647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamarl08
reviewed
Aug 21, 2023
Contributor
|
tested, works! and I see the guidelines when getting the error message, but still worth mentioning it somewhere in the docs. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #647 +/- ##
=======================================
Coverage 95.81% 95.81%
=======================================
Files 32 32
Lines 4444 4444
=======================================
Hits 4258 4258
Misses 186 186 ☔ View full report in Codecov by Sentry. |
damien2012eng
approved these changes
Aug 21, 2023
Collaborator
Author
|
@tamarl08 I updated the docs to link to the commit specification. |
tamarl08
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
contributing.mdto use correct pre-commit install commandTo test this, check out this branch and run the command in
contributing.md. Then try to make a commit with a random commit message, it should fail.