Skip to content

Switch to ruff for pre-commit checks #639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 5 commits into from
Aug 4, 2023
Merged

Switch to ruff for pre-commit checks #639

desilinguist merged 5 commits into from
Aug 4, 2023

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Aug 4, 2023

  • Update pre-commit checks to use ruff instead of flake8, isort, and pydocstyle.
  • Add .ruff.toml file and remove .isort.cfg file.
  • Fix case in one of the docstrings.
  • Update .coveragerc to exclude unneeded file.
  • Add new unit test to increase coverage.

Closes #629.

@codecov
Copy link

codecov bot commented Aug 4, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +2.54% 🎉

Comparison is base (cdc97ae) 93.28% compared to head (98bb6ff) 95.82%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #639      +/-   ##
==========================================
+ Coverage   93.28%   95.82%   +2.54%     
==========================================
  Files          33       32       -1     
  Lines        4972     4430     -542     
==========================================
- Hits         4638     4245     -393     
+ Misses        334      185     -149
Files Changed Coverage Δ
rsmtool/modeler.py 97.64% <ø> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desilinguist desilinguist merged commit 9e0343c into main Aug 4, 2023
@delete-merged-branch delete-merged-branch bot deleted the 629-switch-to-ruff branch August 4, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damien2012eng damien2012eng damien2012eng approved these changes

@dblandan dblandan Awaiting requested review from dblandan

@Frost45 Frost45 Awaiting requested review from Frost45

@tamarl08 tamarl08 Awaiting requested review from tamarl08

+1 more reviewer

@mulhod mulhod mulhod approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace flake8, isort, and pydocstyle with ruff

4 participants

@desilinguist @mulhod @damien2012eng