Skip to content

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Aug 1, 2023

  • Fix broken wandb test.
  • Add missing test_wandb to both CI builds.
  • Remove non-code files from coverage computation by fixing .coveragerc.

Closes #635.

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -2.68% ⚠️

Comparison is base (184982e) 95.88% compared to head (67871fa) 93.21%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
- Coverage   95.88%   93.21%   -2.68%     
==========================================
  Files          60       33      -27     
  Lines        9381     4921    -4460     
==========================================
- Hits         8995     4587    -4408     
+ Misses        386      334      -52     

see 27 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desilinguist desilinguist merged commit 2ed3733 into main Aug 1, 2023
@delete-merged-branch delete-merged-branch bot deleted the 635-wandb-tests branch August 1, 2023 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add wandb tests to CI builds and confirm that they pass

4 participants