Skip to content

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Jul 31, 2023

  • Fix import sorting in RSMExplain's header.ipynb and include additional imports needed for system information.
  • Add sysinfo.ipynb notebook for RSMExplain.
  • Add "sysinfo.ipynb" in default RSMExplain sections in reporter.py.
  • Update RSMExplain documentation to include general_sections option which was missing.
  • Update expected output for auto-generated configuration functions to include "sysinfo".

To test, run the rsmexplain tutorial and confirm that the system information section is included in the report.

Closes #625.

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (09cbed2) 95.88% compared to head (d69138a) 95.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #633   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          60       60           
  Lines        9378     9378           
=======================================
  Hits         8992     8992           
  Misses        386      386           
Files Changed Coverage Δ
rsmtool/reporter.py 92.62% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@desilinguist desilinguist merged commit e03b4f9 into main Jul 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the 625-include-sysinfo-in-rsmexplain branch July 31, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RSMExplain reports should also contain system information

3 participants