Skip to content

Conversation

@desilinguist
Copy link
Collaborator

  • Update SKLL to 4.0
  • Remove use of deprecated SKLL API
  • Handle warning about debugging frozen modules. With python 3.11, it looks like running anything ipython related leads to weird warnings about debugging frozen modules. It's something related to the fact that they import some debugger module internally. So, we need to disable these warnings by setting an environment variable.
  • Update shap in requirements.txt
  • Update conda recipe
  • Update azure pipelines to python 3.11
  • Replace nose functions with native assert in a couple of tests.
  • Update all SKLL models used in tests.
  • Update expected outputs for rsmexplain,

To test, please create an environment with python 3.11, install this and run all of the tutorials and make sure they run successfully and the reports look okay.

This PR closes #606.

@codecov
Copy link

codecov bot commented Jul 29, 2023

Codecov Report

Patch coverage: 69.23% and project coverage change: -0.02% ⚠️

Comparison is base (b1944e0) 95.88% compared to head (57e2a26) 95.87%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   95.88%   95.87%   -0.02%     
==========================================
  Files          60       60              
  Lines        9356     9357       +1     
==========================================
  Hits         8971     8971              
- Misses        385      386       +1     
Files Changed Coverage Δ
tests/test_cli.py 95.93% <ø> (ø)
rsmtool/reporter.py 92.59% <50.00%> (-0.36%) ⬇️
rsmtool/test_utils.py 73.43% <50.00%> (-0.05%) ⬇️
rsmtool/configuration_parser.py 88.48% <100.00%> (+0.03%) ⬆️
tests/test_writer.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tamarl08 tamarl08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested all tutorial reports, looks good!

@desilinguist desilinguist merged commit 83b76fa into main Jul 31, 2023
@delete-merged-branch delete-merged-branch bot deleted the 606-support-python-311 branch July 31, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for Python 3.11

4 participants