Remove unnecessary warnings in HTML reports. #624
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the header notebooks for all tools to exclude the matplotlib and tqdm warnings that were being shown in all the reports.
Replace unnecessary use of `resetwarnings()` with the `catch_warnings()` context manager. This is necessary to ensure that the filtering of warnings in notebooks works as expected.
tamarl08
approved these changes
Jul 27, 2023
Contributor
tamarl08
left a comment
There was a problem hiding this comment.
Tested all the reports and no warnings!
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #624 +/- ##
=======================================
Coverage 95.88% 95.88%
=======================================
Files 60 60
Lines 9356 9356
=======================================
Hits 8971 8971
Misses 385 385
☔ View full report in Codecov by Sentry. |
damien2012eng
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resetwarnings()with thecatch_warnings()context manager infairness_utils.py. This is necessary to ensure that the filtering of warnings in notebooks works as expected.To test this, please check out the branch, run an experiments for each of the command-line tools, and confirm that no warnings are shown in the reports.
This PR closes #618.