Add wandb logging in rsmeval #621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tamarl08
commented
Jul 21, 2023
- Refactored wandb logging to a separate util file and added tests
- Added wandb logging to rsmeval
added 8 commits
July 19, 2023 17:25
…Service/rsmtool into 597-add-wandb-rsmeval
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #621 +/- ##
=======================================
Coverage 95.87% 95.88%
=======================================
Files 59 60 +1
Lines 9339 9348 +9
=======================================
+ Hits 8954 8963 +9
Misses 385 385
☔ View full report in Codecov by Sentry. |
desilinguist
requested changes
Jul 24, 2023
Collaborator
desilinguist
left a comment
There was a problem hiding this comment.
I really like the cleaner wand setup now! Some minor comments.
Collaborator
There was a problem hiding this comment.
Why are files being deleted?
desilinguist
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.