Use example IDs when specifying sample_ids
#613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Assume that `sample_ids` are now actual example IDs instead of indices. - Raise a `ValueError` if anything goes wrong in `select_examples`.
- Use actual string IDs in the test data. - Update all expected outputs to use these new string IDs.
- Update description of `sample_ids` and move it to the end. - Fix some typos.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #613 +/- ##
=======================================
Coverage 95.89% 95.90%
=======================================
Files 59 59
Lines 9286 9297 +11
=======================================
+ Hits 8905 8916 +11
Misses 381 381
☔ View full report in Codecov by Sentry. |
It's possible that a given data file has integers as ID. RSMTool will read them as integers and not strings. In that case, we need to make sure that any sample IDs specified in the configuration file are also converted to the same data type as the featureset IDs before being compared.
tamarl08
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sample_idsare now actual example IDs instead of indices.ValueErrorif anything goes wrong inselect_examples.test_explanation_utils.pytest_experiment_rsmexplain.pyto IDs.sample_idsand move it to the end.Closes #609.