Upgrade shap and unpin numpy
#612
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- We need to update the test outputs since `shap.sample()` behaves differently in 0.42.0.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #612 +/- ##
==========================================
- Coverage 95.89% 95.89% -0.01%
==========================================
Files 59 59
Lines 9289 9286 -3
==========================================
- Hits 8908 8905 -3
Misses 381 381
☔ View full report in Codecov by Sentry. |
Member
damien2012eng
left a comment
There was a problem hiding this comment.
This is awesome! I am glad that we don't have to suppress warnings. Just one suggestion: Can we unpin numpy and shap on the readme.rst?
Collaborator
Author
|
Great catch! Let me do that. |
damien2012eng
approved these changes
Jul 9, 2023
tamarl08
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shapto the recently released 0.42.0.numpy.shapimports since it's no longer required.shap.sample()behaves differently in 0.42.0.Closes #599.