Skip to content

Conversation

@damien2012eng
Copy link
Member

closes #608

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 99.04% and project coverage change: +2.68 🎉

Comparison is base (a1f5a9d) 93.21% compared to head (0de3bb7) 95.90%.

❗ Current head 0de3bb7 differs from pull request most recent head dea0bff. Consider uploading reports for the commit dea0bff to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #610      +/-   ##
==========================================
+ Coverage   93.21%   95.90%   +2.68%     
==========================================
  Files          32       59      +27     
  Lines        4851     9302    +4451     
==========================================
+ Hits         4522     8921    +4399     
- Misses        329      381      +52     
Impacted Files Coverage Δ
tests/test_experiment_rsmxval.py 85.71% <87.50%> (ø)
tests/test_cli.py 95.93% <89.28%> (ø)
tests/test_reporter.py 99.36% <96.87%> (ø)
tests/test_experiment_rsmcompare.py 95.91% <97.36%> (ø)
tests/test_experiment_rsmtool_3.py 96.70% <97.46%> (ø)
tests/test_experiment_rsmexplain.py 96.29% <97.67%> (ø)
tests/test_experiment_rsmsummarize.py 96.49% <97.82%> (ø)
tests/test_experiment_rsmtool_4.py 96.66% <97.95%> (ø)
tests/test_experiment_rsmtool_2.py 96.82% <98.21%> (ø)
tests/test_experiment_rsmeval.py 97.53% <98.57%> (ø)
... and 16 more

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist
Copy link
Collaborator

@damien2012eng I think it's a bit weird that some in some of the test files, you are setting class attributes in setUpClass() using cls.x and in others you are setting them directly in the class definition (e.g. test_cli.py). I think it makes sense to be consistent – if any class attributes are needed, just define them in the class definition. setUpClass() should only be used if you need to create some files or do something else to set up the class other than defining attributes.

@damien2012eng damien2012eng requested a review from tamarl08 July 7, 2023 17:38
Copy link
Collaborator

@desilinguist desilinguist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @damien2012eng!

@desilinguist desilinguist merged commit c580b2e into main Jul 8, 2023
@delete-merged-branch delete-merged-branch bot deleted the migrate_nose_to_nose2 branch July 8, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate from nose to nose2 for testing

5 participants