-
Notifications
You must be signed in to change notification settings - Fork 19
Migrate nose to nose2 #610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #610 +/- ##
==========================================
+ Coverage 93.21% 95.90% +2.68%
==========================================
Files 32 59 +27
Lines 4851 9302 +4451
==========================================
+ Hits 4522 8921 +4399
- Misses 329 381 +52
☔ View full report in Codecov by Sentry. |
|
@damien2012eng I think it's a bit weird that some in some of the test files, you are setting class attributes in |
desilinguist
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @damien2012eng!
closes #608