Restore and increase test coverage #589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Do not install `nose-cov`. - Do not use defaults channel.
Codecov ReportBase: 89.60% // Head: 93.20% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #589 +/- ##
==========================================
+ Coverage 89.60% 93.20% +3.60%
==========================================
Files 31 31
Lines 4549 4549
==========================================
+ Hits 4076 4240 +164
+ Misses 473 309 -164
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Contributor
|
Well, it's unfortunate that it's interacting in this way. |
mulhod
approved these changes
Jan 14, 2023
Collaborator
Author
Yeah it's very strange. I tried lots of things like moving the |
Frost45
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After banging my head against this for a whole day, I finally figured out that adding a
pyproject.tomldisables the measurement of test coverage in subprocesses for some inexplicable reason. This means that we lose coverage of the code in all the entry point scripts under themain()function. I tried lots of solutions but in the end I had to end up deletingpyproject.tomland just rely on other configuration files.Here are the actual changes in this PR:
pyproject.toml..isort.cfgto control isort during development..pre-commit-config.yamlto include all of the flags that we need all the tools to have.defaultschannel or thenose-covPyPI package since they are no longer needed.coverallswithcodecovinrequirements.txt.convert_feature_json.py.