Skip to content

Integrate black and run on all files #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 5 commits into from
Jan 11, 2023
Merged

Integrate black and run on all files #586

desilinguist merged 5 commits into from
Jan 11, 2023

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Jan 11, 2023

  • Add black to pre-commit checks.
  • Run black on all Python files.

@codecov
Copy link

codecov bot commented Jan 11, 2023 •
edited
Loading

Codecov Report

Base: 93.12% // Head: 89.60% // Decreases project coverage by -3.51% ⚠️

Coverage data is based on head (7bbcf80) compared to base (a378451).
Patch coverage: 88.40% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   93.12%   89.60%   -3.52%     
==========================================
  Files          31       31              
  Lines        4551     4551              
==========================================
- Hits         4238     4078     -160     
- Misses        313      473     +160
Impacted Files Coverage Δ
rsmtool/preprocessor.py 96.60% <ø> (ø)
rsmtool/convert_feature_json.py 60.00% <43.75%> (ø)
rsmtool/__init__.py 84.21% <66.66%> (ø)
rsmtool/container.py 92.39% <69.23%> (ø)
rsmtool/rsmxval.py 77.14% <69.56%> (-20.96%) ⬇️
rsmtool/reader.py 88.99% <70.83%> (ø)
rsmtool/rsmcompare.py 66.23% <71.42%> (-28.58%) ⬇️
rsmtool/rsmsummarize.py 69.66% <75.00%> (-28.09%) ⬇️
rsmtool/test_utils.py 72.54% <76.79%> (ø)
rsmtool/rsmeval.py 70.32% <77.50%> (-27.48%) ⬇️
... and 29 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist desilinguist merged commit e7d7ca0 into main Jan 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the 530-integrate-black branch January 11, 2023 22:57
@desilinguist desilinguist mentioned this pull request Jan 11, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damien2012eng damien2012eng damien2012eng approved these changes

@tamarl08 tamarl08 tamarl08 approved these changes

@mulhod mulhod Awaiting requested review from mulhod

@Frost45 Frost45 Awaiting requested review from Frost45

@tazin-afrin tazin-afrin Awaiting requested review from tazin-afrin

@blongwill blongwill Awaiting requested review from blongwill

@amandameganchan amandameganchan Awaiting requested review from amandameganchan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@desilinguist @damien2012eng @tamarl08