Skip to content

Convert all formatted strings to f-strings and add pre-commit with flynt #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
desilinguist merged 5 commits into from
Jan 11, 2023
Merged

Convert all formatted strings to f-strings and add pre-commit with flynt #584

desilinguist merged 5 commits into from
Jan 11, 2023

Conversation

@desilinguist
Copy link
Collaborator

@desilinguist desilinguist commented Jan 10, 2023

Closes #550 and closes #582

  • Add pre-commit to requirements file.
  • Pin sphinx to below v6.0 in requirements file
  • Run flynt on the whole codebase.
  • Add some missing periods and fix some bugs related to formatted strings.

@desilinguist desilinguist self-assigned this Jan 10, 2023
@codecov
Copy link

codecov bot commented Jan 11, 2023 •
edited
Loading

Codecov Report

Base: 93.12% // Head: 93.12% // No change to project coverage 👍

Coverage data is based on head (2a58373) compared to base (722f3b8).
Patch coverage: 80.69% of modified lines in pull request are covered.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   93.12%   93.12%           
=======================================
  Files          31       31           
  Lines        4551     4551           
=======================================
  Hits         4238     4238           
  Misses        313      313
Impacted Files Coverage Δ
rsmtool/utils/cross_validation.py 95.34% <0.00%> (ø)
rsmtool/writer.py 96.00% <33.33%> (ø)
rsmtool/container.py 92.39% <40.00%> (ø)
rsmtool/__init__.py 84.21% <50.00%> (ø)
rsmtool/fairness_utils.py 86.95% <50.00%> (ø)
rsmtool/reader.py 88.99% <50.00%> (ø)
rsmtool/rsmcompare.py 94.80% <50.00%> (ø)
rsmtool/rsmxval.py 98.09% <50.00%> (ø)
rsmtool/modeler.py 97.59% <57.14%> (ø)
rsmtool/test_utils.py 72.54% <63.33%> (ø)
... and 15 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@desilinguist
Copy link
Collaborator Author

desilinguist commented Jan 11, 2023

The codecov failure makes sense as we have probably increased the number of lines but it can be ignored.

@desilinguist desilinguist merged commit a378451 into main Jan 11, 2023
@delete-merged-branch delete-merged-branch bot deleted the 550-convert-all-format-strings-add-flynt branch January 11, 2023 14:56
@desilinguist desilinguist mentioned this pull request Jan 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frost45 Frost45 Frost45 approved these changes

@tamarl08 tamarl08 tamarl08 approved these changes

@mulhod mulhod Awaiting requested review from mulhod

@tazin-afrin tazin-afrin Awaiting requested review from tazin-afrin

@blongwill blongwill Awaiting requested review from blongwill

@amandameganchan amandameganchan Awaiting requested review from amandameganchan

@damien2012eng damien2012eng Awaiting requested review from damien2012eng

Assignees

@desilinguist desilinguist

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Dev environments are broken due to sphinx >= 6.0 Run flynt on all code and add it as a pre-commit hook

4 participants

@desilinguist @Frost45 @tamarl08