Skip to content
This repository was archived by the owner on Aug 7, 2024. It is now read-only.

chore: add Aaquib Ali#975

Merged
Panquesito7 merged 2 commits intoEddieHubCommunity:mainfrom
imaaquibali:aaquib
Jan 14, 2022
Merged

chore: add Aaquib Ali#975
Panquesito7 merged 2 commits intoEddieHubCommunity:mainfrom
imaaquibali:aaquib

Conversation

@imaaquibali
Copy link
Copy Markdown
Member

@imaaquibali imaaquibali commented Jan 12, 2022 •
edited by gitpod-io bot
Loading

Fixes Issue

Changes proposed

Adding links to linkfree in public/data

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

github-actions[bot]
github-actions bot reviewed Jan 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's great having you contribute to this project

Welcome to the community 🤓

If you would like to continue contributing to open source and would like to do it with an awesome inclusive community, you should join our Discord chat and our GitHub Organisation - we help and encourage each other to contribute to open source little and often 🤓 . Any questions let us know.

@EmmaDawsonDev EmmaDawsonDev added the ✍ chore: profile This label will be added on PR with request of Data json addition label Jan 12, 2022
@EmmaDawsonDev EmmaDawsonDev changed the title Adding profile in public/data chore: add Aaquib Ali Jan 12, 2022
gptkrsh
gptkrsh reviewed Jan 12, 2022
View reviewed changes
public/data/aaquibdev.json Outdated

]
}

No newline at end of file
Copy link
Copy Markdown
Contributor

@gptkrsh gptkrsh Jan 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

gptkrsh
gptkrsh reviewed Jan 12, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@gptkrsh gptkrsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the formatting isn't correct It will be done by actions

@imaaquibali
Copy link
Copy Markdown
Member Author

imaaquibali commented Jan 12, 2022

@krishguptadev i done the modification check again if you find any problem plesae tell....?

@imaaquibali
Copy link
Copy Markdown
Member Author

imaaquibali commented Jan 13, 2022

@vikasganiga05 when this Pr is closed..?

@vikasganiga05
Copy link
Copy Markdown
Member

vikasganiga05 commented Jan 13, 2022

@vikasganiga05 when this Pr is closed..?

I don't know. It depends on the maintainers. They will do a final review and merge this PR. 🙂

@EmmaDawsonDev
Copy link
Copy Markdown
Member

EmmaDawsonDev commented Jan 13, 2022

@aaquibdev We usually aim for 2 maintainers to approve the PR before merging :)

Pradumnasaraf
Pradumnasaraf approved these changes Jan 14, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pradumnasaraf Pradumnasaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks for the contribution :D.

@Panquesito7 Panquesito7 merged commit d5ea171 into EddieHubCommunity:main Jan 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

7 more reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@Panquesito7 Panquesito7 Panquesito7 approved these changes

@Pradumnasaraf Pradumnasaraf Pradumnasaraf approved these changes

@EmmaDawsonDev EmmaDawsonDev EmmaDawsonDev approved these changes

@vikasganiga05 vikasganiga05 vikasganiga05 approved these changes

@nathgoutam93 nathgoutam93 nathgoutam93 approved these changes

@gptkrsh gptkrsh gptkrsh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

✍ chore: profile This label will be added on PR with request of Data json addition

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@imaaquibali @vikasganiga05 @EmmaDawsonDev @Panquesito7 @Pradumnasaraf @nathgoutam93 @gptkrsh